#include "moar.h" #define FIXKEY_INITIAL_SIZE_LOG2 3 static void hash_demolish_internal(MVMThreadContext *tc, struct MVMFixKeyHashTableControl *control) { size_t allocated_items = MVM_fixkey_hash_allocated_items(control); size_t entries_size = sizeof(MVMString ***) * allocated_items; char *start = (char *)control - entries_size; MVM_free(start); } /* Frees the entire contents of the hash, leaving you just the hashtable itself, which you allocated (heap, stack, inside another struct, wherever) */ void MVM_fixkey_hash_demolish(MVMThreadContext *tc, MVMFixKeyHashTable *hashtable) { struct MVMFixKeyHashTableControl *control = hashtable->table; if (!control) return; MVMuint32 entries_in_use = MVM_fixkey_hash_kompromat(control); MVMuint8 *entry_raw = MVM_fixkey_hash_entries(control); MVMuint8 *metadata = MVM_fixkey_hash_metadata(control); MVMuint32 bucket = 0; if (control->entry_size) { while (bucket < entries_in_use) { if (*metadata) { MVMString ***indirection = (MVMString ***) entry_raw; MVM_free(*indirection); } ++bucket; ++metadata; entry_raw -= sizeof(MVMString ***); } } hash_demolish_internal(tc, control); hashtable->table = NULL; } /* and then free memory if you allocated it */ MVM_STATIC_INLINE struct MVMFixKeyHashTableControl *hash_allocate_common(MVMThreadContext *tc, MVMuint16 entry_size, MVMuint8 official_size_log2) { MVMuint32 official_size = 1 << (MVMuint32)official_size_log2; MVMuint32 max_items = official_size * MVM_FIXKEY_HASH_LOAD_FACTOR; MVMuint8 max_probe_distance_limit; if (MVM_HASH_MAX_PROBE_DISTANCE < max_items) { max_probe_distance_limit = MVM_HASH_MAX_PROBE_DISTANCE; } else { max_probe_distance_limit = max_items; } size_t allocated_items = official_size + max_probe_distance_limit - 1; size_t entries_size = sizeof(MVMString ***) * allocated_items; size_t metadata_size = MVM_hash_round_size_up(allocated_items + 1); size_t total_size = entries_size + sizeof(struct MVMFixKeyHashTableControl) + metadata_size; assert(total_size == MVM_hash_round_size_up(total_size)); struct MVMFixKeyHashTableControl *control = (struct MVMFixKeyHashTableControl *) ((char *)MVM_malloc(total_size) + entries_size); control->official_size_log2 = official_size_log2; control->max_items = max_items; control->cur_items = 0; control->metadata_hash_bits = MVM_HASH_INITIAL_BITS_IN_METADATA; /* As MVM_HASH_INITIAL_BITS_IN_METADATA is 5, this evaluates to 7: */ MVMuint8 initial_probe_distance = (1 << (8 - MVM_HASH_INITIAL_BITS_IN_METADATA)) - 1; control->max_probe_distance = max_probe_distance_limit > initial_probe_distance ? initial_probe_distance : max_probe_distance_limit; control->max_probe_distance_limit = max_probe_distance_limit; MVMuint8 bucket_right_shift = 8 * sizeof(MVMuint64) - official_size_log2; control->key_right_shift = bucket_right_shift - control->metadata_hash_bits; control->entry_size = entry_size; MVMuint8 *metadata = (MVMuint8 *)(control + 1); memset(metadata, 0, metadata_size); return control; } void MVM_fixkey_hash_build(MVMThreadContext *tc, MVMFixKeyHashTable *hashtable, MVMuint32 entry_size) { if (MVM_UNLIKELY(entry_size > 1024 || entry_size & 3)) { MVM_oops(tc, "Hash table entry_size %" PRIu32 " is invalid", entry_size); } hashtable->table = hash_allocate_common(tc, entry_size, FIXKEY_INITIAL_SIZE_LOG2); } MVM_STATIC_INLINE MVMString ***hash_insert_internal(MVMThreadContext *tc, struct MVMFixKeyHashTableControl *control, MVMString *key) { if (MVM_UNLIKELY(control->cur_items >= control->max_items)) { MVM_oops(tc, "oops, attempt to recursively call grow when adding %p", key); } struct MVM_hash_loop_state ls = MVM_fixkey_hash_create_loop_state(tc, control, key); while (1) { if (*ls.metadata < ls.probe_distance) { /* this is our slot. occupied or not, it is our rightful place. */ if (*ls.metadata == 0) { /* Open goal. Score! */ } else { /* make room. */ /* Optimisation first seen in Martin Ankerl's implementation - we don't need actually implement the "stealing" by swapping elements and carrying on with insert. The invariant of the hash is that probe distances are never out of order, and as all the following elements have probe distances in order, we can maintain the invariant just as well by moving everything along by one. */ MVMuint8 *find_me_a_gap = ls.metadata; MVMuint8 old_probe_distance = *ls.metadata; do { MVMuint32 new_probe_distance = ls.metadata_increment + old_probe_distance; if (new_probe_distance >> ls.probe_distance_shift == ls.max_probe_distance) { /* Optimisation from Martin Ankerl's implementation: setting this to zero forces a resize on any insert, *before* the actual insert, so that we never end up having to handle overflow *during* this loop. This loop can always complete. */ control->max_items = 0; } /* a swap: */ old_probe_distance = *++find_me_a_gap; *find_me_a_gap = new_probe_distance; } while (old_probe_distance); MVMuint32 entries_to_move = find_me_a_gap - ls.metadata; size_t size_to_move = (size_t) ls.entry_size * entries_to_move; /* When we had entries *ascending* this was * memmove(entry_raw + sizeof(MVMString ***), entry_raw, * sizeof(MVMString ***) * entries_to_move); * because we point to the *start* of the block of memory we * want to move, and we want to move it one "entry" forwards. * `entry_raw` is still a pointer to where we want to make free * space, but what want to do now is move everything at it and * *before* it downwards. */ MVMuint8 *dest = ls.entry_raw - size_to_move; memmove(dest, dest + ls.entry_size, size_to_move); } /* The same test and optimisation as in the "make room" loop - we're * about to insert something at the (current) max_probe_distance, so * signal to the next insertion that it needs to take action first. */ if (ls.probe_distance >> ls.probe_distance_shift == control->max_probe_distance) { control->max_items = 0; } ++control->cur_items; *ls.metadata = ls.probe_distance; MVMString ***indirection = (MVMString ***) ls.entry_raw; /* Set this to NULL to signal that this has just been allocated. */ *indirection = NULL; return indirection; } else if (*ls.metadata == ls.probe_distance) { MVMString ***indirection = (MVMString ***) ls.entry_raw; MVMString **entry = *indirection; if (*entry == key || (MVM_string_graphs_nocheck(tc, key) == MVM_string_graphs_nocheck(tc, *entry) && MVM_string_substrings_equal_nocheck(tc, key, 0, MVM_string_graphs_nocheck(tc, key), *entry, 0))) { return indirection; } } ls.probe_distance += ls.metadata_increment; ++ls.metadata; ls.entry_raw -= ls.entry_size; /* For insert, the loop must not iterate to any probe distance greater * than the (current) maximum probe distance, because it must never * insert an entry at a location beyond the maximum probe distance. * * For fetch and delete, the loop is permitted to reach (and read) one * beyond the maximum probe distance (hence +2 in the seemingly * analogous assertions) - but if so, it will always read from the * metadata a probe distance which is lower than the current probe * distance, and hence hit "not found" and terminate the loop. * * This is how the loop terminates when the max probe distance is * reached without needing an explicit test for it, and why we need an * initialised sentinel byte at the end of the metadata. */ assert(ls.probe_distance < (ls.max_probe_distance + 1) * ls.metadata_increment); assert(ls.metadata < MVM_fixkey_hash_metadata(control) + MVM_fixkey_hash_official_size(control) + MVM_fixkey_hash_max_items(control)); assert(ls.metadata < MVM_fixkey_hash_metadata(control) + MVM_fixkey_hash_official_size(control) + 256); } } /* Oh, fsck, I needed to implement this: */ MVMuint64 MVM_fixkey_hash_fsck(MVMThreadContext *tc, MVMFixKeyHashTable *hashtable, MVMuint32 mode); static struct MVMFixKeyHashTableControl *maybe_grow_hash(MVMThreadContext *tc, struct MVMFixKeyHashTableControl *control, MVMString *key) { /* control->max_items may have been set to 0 to trigger a call into this * function. */ MVMuint32 max_items = MVM_fixkey_hash_max_items(control); MVMuint32 max_probe_distance = control->max_probe_distance; MVMuint32 max_probe_distance_limit = control->max_probe_distance_limit; /* We can hit both the probe limit and the max items on the same insertion. * In which case, upping the probe limit isn't going to save us :-) * But if we hit the probe limit max (even without hitting the max items) * then we don't have more space in the metadata, so we're going to have to * grow anyway. */ if (control->cur_items < max_items && max_probe_distance < max_probe_distance_limit) { /* We hit the probe limit, but not the max items count. */ MVMuint32 new_probe_distance = 1 + 2 * max_probe_distance; if (new_probe_distance > max_probe_distance_limit) { new_probe_distance = max_probe_distance_limit; } MVMuint8 *metadata = MVM_fixkey_hash_metadata(control); MVMuint32 in_use_items = MVM_fixkey_hash_official_size(control) + max_probe_distance; /* not `in_use_items + 1` because because we don't need to shift the * sentinel. */ size_t metadata_size = MVM_hash_round_size_up(in_use_items); size_t loop_count = metadata_size / sizeof(unsigned long); unsigned long *p = (unsigned long *) metadata; /* right shift each byte by 1 bit, clearing the top bit. */ do { /* 0x7F7F7F7F7F7F7F7F on 64 bit systems, 0x7F7F7F7F on 32 bit, * but without using constants or shifts larger than 32 bits, or * the preprocessor. (So the compiler checks all code everywhere.) * Will break on a system with 128 bit longs. */ *p = (*p >> 1) & (0x7F7F7F7FUL | (0x7F7F7F7FUL << (4 * sizeof(long)))); ++p; } while (--loop_count); assert(control->metadata_hash_bits); --control->metadata_hash_bits; ++control->key_right_shift; control->max_probe_distance = new_probe_distance; /* Reset this to its proper value. */ control->max_items = max_items; assert(control->max_items); return NULL; } MVMuint32 entries_in_use = MVM_fixkey_hash_kompromat(control); MVMuint8 *entry_raw_orig = MVM_fixkey_hash_entries(control); MVMuint8 *metadata_orig = MVM_fixkey_hash_metadata(control); struct MVMFixKeyHashTableControl *control_orig = control; control = hash_allocate_common(tc, control_orig->entry_size, control_orig->official_size_log2 + 1); MVMuint8 *entry_raw = entry_raw_orig; MVMuint8 *metadata = metadata_orig; MVMHashNumItems bucket = 0; while (bucket < entries_in_use) { if (*metadata) { /* We need to "move" the pointer to entry from the old flat * storage array storage to the new flat storage array. * entry remains as was - that's the whole point of this hashtable * variant - to keep the user-visible structure at a fixed address. */ MVMString ***old_indirection = (MVMString ***) entry_raw; MVMString **entry = *old_indirection; MVMString ***new_indirection = hash_insert_internal(tc, control, *entry); if(*new_indirection) { char *wrong = MVM_string_utf8_encode_C_string(tc, key); MVM_oops(tc, "new_indrection was not NULL in MVM_fixkey_hash_lvalue_fetch_nocheck when adding key %s", wrong); } else { *new_indirection = *old_indirection; } if (!control->max_items) { /* Probably we hit the probe limit. * But it's just possible that one actual "grow" wasn't enough. */ struct MVMFixKeyHashTableControl *new_control = maybe_grow_hash(tc, control, key); if (new_control) { control = new_control; } } } ++bucket; ++metadata; entry_raw -= sizeof(MVMString ***); } hash_demolish_internal(tc, control_orig); return control; } void *MVM_fixkey_hash_lvalue_fetch_nocheck(MVMThreadContext *tc, MVMFixKeyHashTable *hashtable, MVMString *key) { struct MVMFixKeyHashTableControl *control = hashtable->table; if (!control) { /* This isn't going to work. We don't know entry_size, so we can't even * guess, because we would try to allocate 0 bytes, but then try to write * a pointer into it. */ MVM_oops(tc, "Attempting insert on MVM_fixkey_hash without setting entry_size"); } else if (MVM_UNLIKELY(control->cur_items >= control->max_items)) { /* We should avoid growing the hash if we don't need to. * It's expensive, and for hashes with iterators, growing the hash * invalidates iterators. Which is buggy behaviour if the fetch doesn't * need to create a key. */ MVMString **entry = MVM_fixkey_hash_fetch_nocheck(tc, hashtable, key); if (entry) { return entry; } struct MVMFixKeyHashTableControl *new_control = maybe_grow_hash(tc, control, key); if (new_control) { /* We could unconditionally assign this, but that would mean CPU * cache writes even when it was unchanged, and the address of * hashtable will not be in the same cache lines as we are writing * for the hash internals, so it will churn the write cache. */ hashtable->table = control = new_control; } } MVMString ***indirection = hash_insert_internal(tc, control, key); if (!*indirection) { if (!control->entry_size) { /* Assign your static storage here.... */ return indirection; } MVMString **entry = MVM_malloc(control->entry_size); /* and we then set *this* to NULL to signal to our caller that this is a * new allocation. */ *entry = NULL; *indirection = entry; } return *indirection; } /* UNCONDITIONALLY creates a new hash entry with the given key and value. * Doesn't check if the key already exists. Use with care. * (well that's the official line. As you can see, the oops suggests we * currently don't exploit the documented freedom.) */ void *MVM_fixkey_hash_insert_nocheck(MVMThreadContext *tc, MVMFixKeyHashTable *hashtable, MVMString *key) { MVMString **new_entry = MVM_fixkey_hash_lvalue_fetch_nocheck(tc, hashtable, key); if (*new_entry) { /* This footgun has a safety catch. */ MVM_oops(tc, "duplicate key in fixkey_hash_insert"); } else if (hashtable->table->entry_size) { *new_entry = key; } else { /* This is the special case entry_size == 0, and the returned value * new_entry is actually the address inside the hash to be assigned to. */ } return new_entry; } /* This is not part of the public API, and subject to change at any point. (possibly in ways that are actually incompatible but won't generate compiler warnings.) */ MVMuint64 MVM_fixkey_hash_fsck(MVMThreadContext *tc, MVMFixKeyHashTable *hashtable, MVMuint32 mode) { struct MVMFixKeyHashTableControl *control = hashtable->table; const char *prefix_hashes = mode & 1 ? "# " : ""; MVMuint32 display = (mode >> 1) & 3; MVMuint64 errors = 0; MVMuint64 seen = 0; if (MVM_fixkey_hash_entries(control) == NULL) { return 0; } MVMuint32 entries_in_use = MVM_fixkey_hash_kompromat(control); MVMuint8 *entry_raw = MVM_fixkey_hash_entries(control); MVMuint8 *metadata = MVM_fixkey_hash_metadata(control); MVMuint32 bucket = 0; MVMint64 prev_offset = 0; MVMuint8 bucket_right_shift = control->key_right_shift + control->metadata_hash_bits; while (bucket < entries_in_use) { if (!*metadata) { /* empty slot. */ prev_offset = 0; if (display == 2) { fprintf(stderr, "%s%3X\n", prefix_hashes, bucket); } } else { ++seen; MVMString ***indirection = (MVMString ***) entry_raw; if (!indirection) { ++errors; fprintf(stderr, "%s%3X!\n", prefix_hashes, bucket); } else { MVMString **entry = *indirection; if (!entry) { ++errors; fprintf(stderr, "%s%3X!!\n", prefix_hashes, bucket); } else { MVMuint64 hash_val = MVM_string_hash_code(tc, *entry); MVMuint32 ideal_bucket = hash_val >> bucket_right_shift; MVMint64 offset = 1 + bucket - ideal_bucket; int wrong_bucket = offset != *metadata; int wrong_order = offset < 1 || offset > prev_offset + 1; if (display == 2 || wrong_bucket || wrong_order) { MVMuint64 len = MVM_string_graphs(tc, *entry); char *key = MVM_string_utf8_encode_C_string(tc, *entry); fprintf(stderr, "%s%3X%c%3"PRIx64"%c%0"PRIx64" (%"PRIu64") %s\n", prefix_hashes, bucket, wrong_bucket ? '!' : ' ', offset, wrong_order ? '!' : ' ', hash_val, len, key); errors += wrong_bucket + wrong_order; } prev_offset = offset; } } } ++bucket; ++metadata; entry_raw -= sizeof(MVMString ***); } if (*metadata != 0) { ++errors; if (display) { fprintf(stderr, "%s %02x!\n", prefix_hashes, *metadata); } } if (seen != control->cur_items) { ++errors; if (display) { fprintf(stderr, "%s %"PRIx64"u != %"PRIx32"u \n", prefix_hashes, seen, control->cur_items); } } return errors; }